k9s/internal
jfremy-openai f957fd6739
fetchContainers(allContainers=false) returns sidecars and ephemeral (#3415)
Issue: when calling exec / attach on a pod with sidecar containers or ephemeral containers, those are not presented as potential targets to exec / attach / transfer.

Proposed solution: the method fetchContainers is only called with allContainers=false to find containers we can exec / attach / transfer.
Both ephemeral containers and sidecar init containers could be used in this case however with the current behavior they're not shown.

I'm proposing to change the behavior of the method to return any sidecar container and ephemeral container when called with allContainers=false since there is no other caller using that parameter set to false, so we won't break other call sites
2025-06-28 08:54:26 -06:00
..
client Rel v0.50.6 (#3338) 2025-05-11 23:16:37 -06:00
color Rel v0.50.0 (#3254) 2025-04-08 23:40:34 -06:00
config Rel v0.50.5 (#3332) 2025-05-07 23:22:01 -06:00
dao revert: #3322 (#3346) 2025-05-17 08:28:01 -06:00
health Rel v0.50.0 (#3254) 2025-04-08 23:40:34 -06:00
model Rel v0.50.6 (#3338) 2025-05-11 23:16:37 -06:00
model1 Rel v0.50.6 (#3338) 2025-05-11 23:16:37 -06:00
perf Rel v0.50.3 (#3276) 2025-04-13 18:25:04 -06:00
port Rel v0.50.6 (#3338) 2025-05-11 23:16:37 -06:00
render Rel v0.50.6 (#3338) 2025-05-11 23:16:37 -06:00
slogs Rel v0.50.5 (#3332) 2025-05-07 23:22:01 -06:00
tchart Rel v0.50.5 (#3332) 2025-05-07 23:22:01 -06:00
ui Rel v0.50.5 (#3332) 2025-05-07 23:22:01 -06:00
view fetchContainers(allContainers=false) returns sidecars and ephemeral (#3415) 2025-06-28 08:54:26 -06:00
vul Rel v0.50.4 (#3293) 2025-04-19 12:07:10 -06:00
watch Rel v0.50.3 (#3276) 2025-04-13 18:25:04 -06:00
xray Rel v0.50.0 (#3254) 2025-04-08 23:40:34 -06:00
helpers.go Rel v0.50.0 (#3254) 2025-04-08 23:40:34 -06:00
helpers_test.go K9s/release v0.32.0 (#2577) 2024-03-02 10:18:47 -07:00
keys.go K9s Release v0.29.0 (#2326) 2023-12-06 23:12:39 -07:00
pool.go Rel v0.50.0 (#3254) 2025-04-08 23:40:34 -06:00
pool_test.go Rel v0.50.0 (#3254) 2025-04-08 23:40:34 -06:00