Issue: when calling exec / attach on a pod with sidecar containers or ephemeral containers, those are not presented as potential targets to exec / attach / transfer.
Proposed solution: the method fetchContainers is only called with allContainers=false to find containers we can exec / attach / transfer.
Both ephemeral containers and sidecar init containers could be used in this case however with the current behavior they're not shown.
I'm proposing to change the behavior of the method to return any sidecar container and ephemeral container when called with allContainers=false since there is no other caller using that parameter set to false, so we won't break other call sites
When a CRD's GV contained k8s.io (e.g.
infrastructure.cluster.x-k8s.io/v1beta1), it was considered as standard
resource, therefore no alias was generated in the form of
"<name>.<group>", therefore the CRD list view could not open the listing
of that specific CRD.
* fix(coloring): invalid color application for rows with VALID column
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
* tests(pod): new valid function needs different test fixtures
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
* fix: fix tests without introducing a regression bug
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
---------
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
* Update deprecated yaml.v2->v3
* [Fix] fix issue with yaml sanitization when [] or [xxx] are present
* Spring cleanup
* fix#3192
* Column Blow Reloaded
* Add ability to use alias when specifying custom views
Currently, running the cronjob trigger command supports
triggering the currently selected cronjob only. It would
be nice if this feature supported triggering all marked
cronjobs in the case that there are marked cronjobs - in
a similar fashion to scaling deployments or generally
deleting resources.
Let's modify cronjob triggering to support the case where
the user has marked multiple cronjobs in the cronjob view.
Fixes#3166
Throughout the code, pushCmd is used for when a command is being executed (switched to) to conditionally add the new command onto the history. The history commands (keybinds `[`, `]`, `-`) only navigate through the stack with indices and therefore should never manipulate the stack -- however with some special commands (specialCmd), navigating to those commands previously unconditionally added the command to the stack unlike "typical" commands like `pods`, `svc`.
Here we pass in the pushCmd boolean to all appropriate special commands so that if the stack should not be manipulated, they do not push their command onto the stack.
The original issue reported issues with Aliases, but there were unreported bugs with Namespaces and Contexts as well. Notably, RBAC commands and Dir commands were not modified as they do not push their command onto the history stack, functioning more as "virtual" commands that will not appear in the history.
* fix#3119 - non alpha cust col
* Address issues:
o fix#3118 - wrong res shown on alias
o fix#3120 - shuffled cols after sort
* fix#3122 - view event not sorted
* rel v0.40.4
* Make menu foreground style configurable through skins
* Added menu fgStyle info to README
---------
Co-authored-by: Fernand Galiana <fernand.galiana@gmail.com>
* feat(app): add Go Back and Last View
Go Back walks back through the history until at the oldest saved view
Last View switches between the current and previous views like how "cd -" works
* feat(history): add keyboard shortcuts to navigate history
* fix(tests): fix history/app tests
* docs(README): update history and last command navigation info
* fix(internal): add missing parameter
* feat(help): add history keybinds
* fix(help): adjust capitalization for history commands
* docs(readme): fix typo
Co-authored-by: merusso <merusso@gmail.com>
---------
Co-authored-by: merusso <merusso@gmail.com>
Fernand Galiana
Alex Trinker
Maurizio Pasquinelli
jfremy-openai
Ümüt Özalp
Youssef Rabie
Rudrakh Panigrahi
Vageesha B R
Max Xu
tscuite
Arriv9l
Sunggun Yu
Jason Tackaberry
D54
Aaron Schweig
Hyeonmin Park
Erich Fussi
DanCocking
tyzbit
Clément Rezvoy
rhslack
Jayson Wang
Audun Stien
jesko
Albert Gustavsson