From e5cdf04e51d4ac39b3d09e90cb102c7c8ef7b5fc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=9Cm=C3=BCt=20=C3=96zalp?=
 <54961032+uozalp@users.noreply.github.com>
Date: Mon, 1 Dec 2025 17:40:33 +0100
Subject: [PATCH] fix for scale option appearing on non-scalable resources
 (#3696)

* fix: simplify scaling key binding condition

* fix: add ReplicaSet to scalable resource check

* fix: update expected hints count in deployment and stateful set tests
---
 internal/dao/registry.go        | 2 +-
 internal/view/dp_test.go        | 2 +-
 internal/view/scale_extender.go | 2 +-
 internal/view/sts_test.go       | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/internal/dao/registry.go b/internal/dao/registry.go
index 090b19ba..d4c88947 100644
--- a/internal/dao/registry.go
+++ b/internal/dao/registry.go
@@ -356,7 +356,7 @@ func isStandardGroup(gv string) bool {
 }
 
 func isScalable(gvr *client.GVR) bool {
-	ss := sets.New(client.DpGVR, client.StsGVR)
+	ss := sets.New(client.DpGVR, client.StsGVR, client.RsGVR)
 
 	return ss.Has(gvr)
 }
diff --git a/internal/view/dp_test.go b/internal/view/dp_test.go
index 685a95c3..fe7b9700 100644
--- a/internal/view/dp_test.go
+++ b/internal/view/dp_test.go
@@ -17,5 +17,5 @@ func TestDeploy(t *testing.T) {
 
 	require.NoError(t, v.Init(makeCtx(t)))
 	assert.Equal(t, "Deployments", v.Name())
-	assert.Len(t, v.Hints(), 18)
+	assert.Len(t, v.Hints(), 17)
 }
diff --git a/internal/view/scale_extender.go b/internal/view/scale_extender.go
index 04ad9d54..f9e4d00b 100644
--- a/internal/view/scale_extender.go
+++ b/internal/view/scale_extender.go
@@ -44,7 +44,7 @@ func (s *ScaleExtender) bindKeys(aa *ui.KeyActions) {
 		return
 	}
 
-	if !dao.IsCRD(meta) || dao.IsScalable(meta) {
+	if dao.IsScalable(meta) {
 		aa.Add(ui.KeyS, ui.NewKeyActionWithOpts("Scale", s.scaleCmd,
 			ui.ActionOpts{
 				Visible:   true,
diff --git a/internal/view/sts_test.go b/internal/view/sts_test.go
index d67f57b8..0ff5d12d 100644
--- a/internal/view/sts_test.go
+++ b/internal/view/sts_test.go
@@ -17,5 +17,5 @@ func TestStatefulSetNew(t *testing.T) {
 
 	require.NoError(t, s.Init(makeCtx(t)))
 	assert.Equal(t, "StatefulSets", s.Name())
-	assert.Len(t, s.Hints(), 15)
+	assert.Len(t, s.Hints(), 14)
 }