From 57d6906ef6399968ede8605dfb8533e0fa63aad4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C4=9Bmec?= Date: Sat, 4 Apr 2020 19:00:09 +0200 Subject: [PATCH 1/2] Log view: Allow persisting text wrap and timestamp --- internal/config/config_test.go | 4 ++++ internal/config/logger.go | 2 ++ internal/view/log.go | 2 +- internal/view/log_indicator.go | 2 ++ 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/internal/config/config_test.go b/internal/config/config_test.go index 013d9648..d255a01e 100644 --- a/internal/config/config_test.go +++ b/internal/config/config_test.go @@ -269,6 +269,8 @@ var expectedConfig = `k9s: buffer: 800 sinceSeconds: -1 fullScreenLogs: false + textWrap: false + showTime: false currentContext: blee currentCluster: blee clusters: @@ -320,6 +322,8 @@ var resetConfig = `k9s: buffer: 2000 sinceSeconds: -1 fullScreenLogs: false + textWrap: false + showTime: false currentContext: blee currentCluster: blee clusters: diff --git a/internal/config/logger.go b/internal/config/logger.go index be3fee73..66f0d1bb 100644 --- a/internal/config/logger.go +++ b/internal/config/logger.go @@ -19,6 +19,8 @@ type Logger struct { BufferSize int `yaml:"buffer"` SinceSeconds int64 `yaml:"sinceSeconds"` FullScreenLogs bool `yaml:"fullScreenLogs"` + TextWrap bool `yaml:"textWrap"` + ShowTime bool `yaml:"showTime"` } // NewLogger returns a new instance. diff --git a/internal/view/log.go b/internal/view/log.go index fa289725..417341d1 100644 --- a/internal/view/log.go +++ b/internal/view/log.go @@ -76,7 +76,7 @@ func (l *Log) Init(ctx context.Context) (err error) { } l.logs.SetBorderPadding(0, 0, 1, 1) l.logs.SetText(logMessage) - l.logs.SetWrap(false) + l.logs.SetWrap(l.app.Config.K9s.Logger.TextWrap) l.logs.SetMaxBuffer(l.app.Config.K9s.Logger.BufferSize) l.logs.cmdBuff.AddListener(l) diff --git a/internal/view/log_indicator.go b/internal/view/log_indicator.go index 93e01d8f..5696a0b4 100644 --- a/internal/view/log_indicator.go +++ b/internal/view/log_indicator.go @@ -26,6 +26,8 @@ func NewLogIndicator(cfg *config.Config, styles *config.Styles) *LogIndicator { TextView: tview.NewTextView(), scrollStatus: 1, fullScreen: cfg.K9s.Logger.FullScreenLogs, + textWrap: cfg.K9s.Logger.TextWrap, + showTime: cfg.K9s.Logger.ShowTime, } l.StylesChanged(styles) styles.AddListener(&l) From d026dea25fa5f56c07f60f997c6d0a487e4a7b4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Posp=C3=AD=C5=A1ek?= Date: Thu, 9 Apr 2020 10:56:22 +0200 Subject: [PATCH 2/2] better documentation for xray Fixes #642 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0bbd4b1d..8b1c71e6 100644 --- a/README.md +++ b/README.md @@ -161,7 +161,7 @@ K9s uses aliases to navigate most K8s resources. | To delete a resource (TAB and ENTER to confirm) | `ctrl-d` | | | To kill a resource (no confirmation dialog!) | `ctrl-k` | | | Launch pulses view | `:`pulses or pu⏎ | | -| Launch XRay view | `:`xray pod⏎ | accepts po, svc, dp, rs, sts or ds | +| Launch XRay view | `:`xray RESOURCE [NAMESPACE]⏎ | RESOURCE can be one of po, svc, dp, rs, sts, ds, NAMESPACE is optional | ---