Test refactored using table testing

mine
Lorenzo Torracchi 2019-10-30 10:59:31 +01:00
parent 82b5a9cee7
commit b84dfff458
1 changed files with 29 additions and 18 deletions

View File

@ -44,26 +44,37 @@ func TestPodFields(t *testing.T) {
assert.Equal(t, "fred", r[0]) assert.Equal(t, "fred", r[0])
} }
func TestPodFieldsPercentageCpuAndMemRelatedToContainerRequestSpec(t *testing.T) { func TestPodFieldsPercentageCpuAndMemRelatedToContainerRequestSpecAndFallbackToLimit(t *testing.T) {
metrics := makeMxPod("fred", "250m", "256Mi") percentageTests := []struct {
resources v1.ResourceRequirements
r := NewPodWithMetrics(metrics, v1.ResourceRequirements{ metrics mv1beta1.PodMetrics
expectedCpuPercentage string
expectedMemPercentage string
}{
{
v1.ResourceRequirements{
Requests: makeRes("500m", "512Mi"), Requests: makeRes("500m", "512Mi"),
}).Fields("blee") },
makeMxPod("fred", "250m", "256Mi"),
assert.Equal(t, "150", r[6]) "150",
assert.Equal(t, "150", r[7]) "150",
},
{
v1.ResourceRequirements{
Limits: makeRes("1000m", "1024Mi"),
},
makeMxPod("fred", "250m", "256Mi"),
"75",
"75",
},
} }
func TestPodFieldsPercentageCpuAndMemFallbackToContainerLimitSpecWhenRequestNotDefined(t *testing.T) { for _, percentageTest := range percentageTests {
metrics := makeMxPod("fred", "250m", "256Mi") r := NewPodWithMetrics(percentageTest.metrics, percentageTest.resources).Fields("blee")
r := NewPodWithMetrics(metrics, v1.ResourceRequirements{ assert.Equal(t, percentageTest.expectedCpuPercentage, r[6])
Limits: makeRes("1000m", "1024Mi"), assert.Equal(t, percentageTest.expectedMemPercentage, r[7])
}).Fields("blee") }
assert.Equal(t, "75", r[6])
assert.Equal(t, "75", r[7])
} }
func TestPodMarshal(t *testing.T) { func TestPodMarshal(t *testing.T) {