fix race conditions

internal/dao/table.go

@@ -46,7 +46,6 @@ func (t *Table) Get(ctx context.Context, path string) (runtime.Object, error) {
 
 // List all Resources in a given namespace.
 func (t *Table) List(ctx context.Context, ns string) ([]runtime.Object, error) {
-	log.Debug().Msgf("TABLE-LIST %q:%q", ns, t.gvr)
 	a := fmt.Sprintf(gvFmt, metav1beta1.SchemeGroupVersion.Version, metav1beta1.GroupName)
 	_, codec := t.codec()
 

internal/model/table.go

@@ -2,7 +2,6 @@ package model
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"sync"
 	"sync/atomic"
@@ -186,7 +185,6 @@ func (t *Table) updater(ctx context.Context) {
 	for {
 		select {
 		case <-ctx.Done():
-			t.fireTableLoadFailed(errors.New("operation canceled"))
 			return
 		case <-time.After(rate):
 			rate = t.refreshRate
@@ -207,7 +205,7 @@ func (t *Table) refresh(ctx context.Context) {
 		t.fireTableLoadFailed(err)
 		return
 	}
-	t.fireTableChanged()
+	t.fireTableChanged(t.Peek())
 }
 
 func (t *Table) list(ctx context.Context, a dao.Accessor) ([]runtime.Object, error) {
@@ -261,7 +259,6 @@ func (t *Table) reconcile(ctx context.Context) error {
 
 	t.mx.Lock()
 	defer t.mx.Unlock()
-
 	// if labelSelector in place might as well clear the model data.
 	sel, ok := ctx.Value(internal.KeyLabels).(string)
 	if ok && sel != "" {
@@ -300,8 +297,7 @@ func (t *Table) resourceMeta() ResourceMeta {
 	return meta
 }
 
-func (t *Table) fireTableChanged() {
-	data := t.Peek()
+func (t *Table) fireTableChanged(data render.TableData) {
 	for _, l := range t.listeners {
 		l.TableDataChanged(data)
 	}

internal/render/row.go

@@ -13,9 +13,8 @@ type Fields []string
 // Clone returns a copy of the fields.
 func (f Fields) Clone() Fields {
 	cp := make(Fields, len(f))
-	for i, v := range f {
-		cp[i] = v
-	}
+	copy(cp, f)
+
 	return cp
 }
 

internal/render/table_data.go

@@ -19,11 +19,11 @@ func (t *TableData) Clear() {
 
 // Clone returns a copy of the table
 func (t *TableData) Clone() TableData {
-	return cloneTable(*t)
+	return TableData{
+		Header:    t.Header.Clone(),
+		RowEvents: t.RowEvents.Clone(),
+		Namespace: t.Namespace,
 	}
-
-func cloneTable(t TableData) TableData {
-	return t
 }
 
 // SetHeader sets table header.

internal/ui/flash.go

@@ -134,8 +134,7 @@ func (f *Flash) SetMessage(level FlashLevel, msg ...string) {
 	}
 
 	var ctx context.Context
-	ctx, f.cancel = context.WithCancel(context.TODO())
-	ctx, f.cancel = context.WithTimeout(ctx, flashDelay)
+	ctx, f.cancel = context.WithTimeout(context.Background(), flashDelay)
 	go f.refresh(ctx)
 }
 

internal/ui/logo.go

@@ -3,8 +3,6 @@ package ui
 import (
 	"fmt"
 
-	"github.com/gdamore/tcell"
-
 	"github.com/derailed/k9s/internal/config"
 	"github.com/derailed/tview"
 )
@@ -29,6 +27,7 @@ func NewLogo(styles *config.Styles) *Logo {
 	l.AddItem(l.logo, 0, 6, false)
 	l.AddItem(l.status, 0, 1, false)
 	l.refreshLogo(styles.Body().LogoColor)
+	l.SetBackgroundColor(styles.BgColor())
 	styles.AddListener(&l)
 
 	return &l
@@ -96,7 +95,6 @@ func (l *Logo) refreshLogo(c string) {
 
 func logo() *tview.TextView {
 	v := tview.NewTextView()
-	v.SetBackgroundColor(tcell.ColorDefault)
 	v.SetWordWrap(false)
 	v.SetWrap(false)
 	v.SetTextAlign(tview.AlignLeft)
@@ -107,7 +105,6 @@ func logo() *tview.TextView {
 
 func status() *tview.TextView {
 	v := tview.NewTextView()
-	v.SetBackgroundColor(tcell.ColorDefault)
 	v.SetWordWrap(false)
 	v.SetWrap(false)
 	v.SetTextAlign(tview.AlignCenter)

internal/view/app.go

@@ -169,6 +169,7 @@ func (a *App) buildHeader() tview.Primitive {
 func (a *App) Halt() {
 	if a.cancelFn != nil {
 		a.cancelFn()
+		a.cancelFn = nil
 	}
 }
 
@@ -311,19 +312,21 @@ func (a *App) Run() error {
 
 // Status reports a new app status for display.
 func (a *App) Status(l ui.FlashLevel, msg string) {
+	a.QueueUpdateDraw(func() {
 		a.Flash().SetMessage(l, msg)
 		a.setIndicator(l, msg)
 		a.setLogo(l, msg)
-	a.Draw()
+	})
 }
 
 // ClearStatus reset logo back to normal.
 func (a *App) ClearStatus(flash bool) {
+	a.QueueUpdateDraw(func() {
 		a.Logo().Reset()
 		if flash {
 			a.Flash().Clear()
 		}
-	a.Draw()
+	})
 }
 
 func (a *App) setLogo(l ui.FlashLevel, msg string) {

internal/view/xray.go

@@ -160,6 +160,8 @@ func (x *Xray) refreshActions() {
 	}
 
 	switch gvr {
+	case "v1/namespaces":
+		x.Actions().Delete(tcell.KeyEnter)
 	case "containers":
 		x.Actions().Delete(tcell.KeyEnter)
 		aa[ui.KeyS] = ui.NewKeyAction("Shell", x.shellCmd, true)

internal/watch/factory.go

@@ -109,10 +109,14 @@ func (f *Factory) waitForCacheSync(ns string) {
 	if f.isClusterWide() {
 		ns = client.AllNamespaces
 	}
+
+	f.mx.RLock()
+	defer f.mx.RUnlock()
 	fac, ok := f.factories[ns]
 	if !ok {
 		return
 	}
+
 	// Hang for a sec for the cache to refresh if still not done bail out!
 	c := make(chan struct{})
 	go func(c chan struct{}) {