jayjay
/
k9s
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #586 from sjones303/FixPortCheck 

Use address:port tuple when checking port forwarding
mine
Fernand Galiana 2020-02-28 22:30:40 -07:00 committed by GitHub
parent e760b2c176 9bb9f677fa
commit 2fa4d5f784
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/view/pf_extender.go
View File

@ -72,8 +72,8 @@ func (p *PortForwardExtender) fetchPodName(path string) (string, error) {
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------
// Helpers... // Helpers...
func tryListenPort(port string) error { func tryListenPort(address, port string) error {
server, err := net.Listen("tcp", fmt.Sprintf(":%s", port)) server, err := net.Listen("tcp", fmt.Sprintf("%s:%s", address, port))
if err != nil { if err != nil {
return err return err
} }
@ -101,7 +101,7 @@ func runForward(v ResourceViewer, pf watch.Forwarder, f *portforward.PortForward
} }
func startFwdCB(v ResourceViewer, path, co string, t client.PortTunnel) { func startFwdCB(v ResourceViewer, path, co string, t client.PortTunnel) {
err := tryListenPort(t.LocalPort) err := tryListenPort(t.Address, t.LocalPort)
if err != nil { if err != nil {
v.App().Flash().Err(err) v.App().Flash().Err(err)
return return