jayjay
/
k9s
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix #3601 - fails to modify or delete namespaces using RBAC (#3671)

mine
SebPlv 2025-11-12 17:22:13 +01:00 committed by GitHub
parent b49e3f4a27
commit 2bf2f481ef
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/client/client.go
View File

@ -150,6 +150,10 @@ func (a *APIClient) CanI(ns string, gvr *GVR, name string, verbs []string) (auth
if !a.getConnOK() {
return false, errors.New("ACCESS -- No API server connection")
}
if gvr == NsGVR {
// The name of the namespace is required to check permissions in some cases
ns = name
}
if IsClusterWide(ns) {
ns = BlankNamespace
}

3
internal/view/browser.go
View File

@ -519,9 +519,6 @@ func editRes(app *App, gvr *client.GVR, path string) error {
if client.IsClusterScoped(ns) {
ns = client.BlankNamespace
}
if gvr == client.NsGVR {
n = ns
}
if ok, err := app.Conn().CanI(ns, gvr, n, client.PatchAccess); !ok || err != nil {
return fmt.Errorf("current user can't edit resource %s", gvr)
}

6
internal/watch/factory.go
View File

@ -201,11 +201,7 @@ func (f *Factory) isClusterWide() bool {
// CanForResource return an informer is user has access.
func (f *Factory) CanForResource(ns string, gvr *client.GVR, verbs []string) (informers.GenericInformer, error) {
var resName string
if gvr == client.NsGVR {
resName = ns
}
auth, err := f.Client().CanI(ns, gvr, resName, verbs)
auth, err := f.Client().CanI(ns, gvr, "", verbs)
if err != nil {
return nil, err
}