From 242d97956b79b42ba66a5c08cb2a9f4b6aedacb2 Mon Sep 17 00:00:00 2001 From: derailed Date: Thu, 18 Apr 2019 19:12:06 -0600 Subject: [PATCH] cleanup and bug fixes --- .goreleaser.yml | 9 ++++++++- change_logs/release_0.5.1.md | 29 +++++++++++++++++++++++++++++ internal/views/pod.go | 5 +++++ internal/views/resource.go | 7 ++++++- internal/views/table.go | 9 ++++++--- 5 files changed, 54 insertions(+), 5 deletions(-) create mode 100644 change_logs/release_0.5.1.md diff --git a/.goreleaser.yml b/.goreleaser.yml index 7db847b6..9b4e2615 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -80,4 +80,11 @@ snapcraft: confinement: strict apps: k9s: - plugs: ["home", "network"] + plugs: ["home", "network", "personal-files"] + plugs: + personal-files: + read: + - $HOME/.k9s + - $HOME/.kube + write: + - $HOME/.k9s \ No newline at end of file diff --git a/change_logs/release_0.5.1.md b/change_logs/release_0.5.1.md new file mode 100644 index 00000000..c70dc79f --- /dev/null +++ b/change_logs/release_0.5.1.md @@ -0,0 +1,29 @@ + + +# Release v0.5.1 + +## Notes + +Thank you to all that contributed with flushing out issues with K9s! I'll try to mark some of these issues as fixed. But if you don't mind grab the latest rev and see if we're happier with some of the fixes! + +If you've filed an issue please help me verify and close. + +Thank you so much for your support and awesome suggestions to make K9s better!! + +Also if you dig this tool, please make some noise on social! [@kitesurfer](https://twitter.com/kitesurfer) + +--- + +## Change Logs + +Minor code cleanup and some display bug fixes. + +--- + +## Resolved Bugs + ++ [Issue #168](https://github.com/derailed/k9s/issues/168) + +--- + + © 2019 Imhotep Software LLC. All materials licensed under [Apache v2.0](http://www.apache.org/licenses/LICENSE-2.0) diff --git a/internal/views/pod.go b/internal/views/pod.go index 9c46015a..3cfb9b76 100644 --- a/internal/views/pod.go +++ b/internal/views/pod.go @@ -46,6 +46,11 @@ func newPodView(t string, app *appView, list resource.List) resourceViewer { } func (v *podView) listContainers(app *appView, _, res, sel string) { + if !v.rowSelected() { + return + } + + log.Debug().Msgf("Selected %s", sel) ns, n := namespaced(sel) po, err := app.conn().DialOrDie().CoreV1().Pods(ns).Get(n, metav1.GetOptions{}) if err != nil { diff --git a/internal/views/resource.go b/internal/views/resource.go index c6fef247..f90c719c 100644 --- a/internal/views/resource.go +++ b/internal/views/resource.go @@ -149,7 +149,12 @@ func (v *resourceView) setDecorateFn(f decorateFn) { // ---------------------------------------------------------------------------- // Actions... -func (v *resourceView) enterCmd(*tcell.EventKey) *tcell.EventKey { +func (v *resourceView) enterCmd(evt *tcell.EventKey) *tcell.EventKey { + // If in command mode run filter otherwise enter function. + if v.getTV().filterCmd(evt) == nil { + return nil + } + if v.enterFn != nil { v.enterFn(v.app, v.list.GetNamespace(), v.list.GetName(), v.selectedItem) } else { diff --git a/internal/views/table.go b/internal/views/table.go index 608bf7b0..38c5ef26 100644 --- a/internal/views/table.go +++ b/internal/views/table.go @@ -136,10 +136,13 @@ func (v *tableView) pageDownCmd(evt *tcell.EventKey) *tcell.EventKey { } func (v *tableView) filterCmd(evt *tcell.EventKey) *tcell.EventKey { - v.cmdBuff.setActive(false) - v.refresh() + if v.cmdBuff.isActive() { + v.cmdBuff.setActive(false) + v.refresh() + return nil + } - return nil + return evt } func (v *tableView) eraseCmd(evt *tcell.EventKey) *tcell.EventKey {